refactor: change isDepositMode to getTransferMode #2031
+259
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fionnachan
commented
Oct 28, 2024
packages/arb-token-bridge-ui/src/util/__tests__/isDepositMode.test.ts
Outdated
Show resolved
Hide resolved
fionnachan
commented
Oct 28, 2024
packages/arb-token-bridge-ui/src/util/__tests__/isDepositMode.test.ts
Outdated
Show resolved
Hide resolved
chrstph-dvx
reviewed
Dec 13, 2024
| it('should return true for L2 source chain and L3 destination chain', () => { | ||
| const result1 = isDepositMode({ | ||
| sourceChainId: ChainId.ArbitrumOne, | ||
| destinationChainId: 660279 // Xai |
There was a problem hiding this comment.
Not related to this PR, but it would be nice to have enum for chain ids somewhere
There was a problem hiding this comment.
perhaps we can generate enums from the orbit chains data json, but i think the original idea was to only keep core chain's ids as enum
There was a problem hiding this comment.
for this test at least, we could move the definition of the chain ids to the outer scope so we don't need to add comments every time.
chrstph-dvx
previously approved these changes
Dec 13, 2024
douglance
previously approved these changes
Dec 13, 2024
spsjvc
requested changes
Dec 18, 2024
fionnachan
dismissed stale reviews from douglance and chrstph-dvx
via
b2c7fb4
fionnachan
changed the title
fionnachan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FS-929